This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ready for merge yet, but I just wanted to get a sense of what would be required to even import GeometryTypes in Julia v0.6-dev.
The tests don't all pass, because there seem to be issues with FixedSizeArrays
fsa_abstract()
like:but this at least fixes failures on import.
The primary change is that in Julia v0.6, if you have an abstract type:
then you can't subtype from
Foo
(without the parameter). So this is an error:but this is still OK:
See: JuliaLang/julia#19414
The fix was to explicitly include the
N
andT
parameters in the various Mesh types so that we can haveabstract AbstractMesh{N, T, VertT, FaceT} <: AbstractGeometry{N, T}
instead ofabstract AbstractMesh{VertT, FaceT} <: AbstractGeometry
Now that we have triangular dispatch in v0.6, it might be possible to do this in a more clever way. I'm not sure yet.