Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would you allow HyperSphere(radius::Real, D::Int) ? #201

Open
Datseris opened this issue Jul 31, 2023 · 2 comments · May be fixed by #232
Open

Would you allow HyperSphere(radius::Real, D::Int) ? #201

Datseris opened this issue Jul 31, 2023 · 2 comments · May be fixed by #232

Comments

@Datseris
Copy link

that would make a hypersphere of dimenions D with center the 0 vector in D dimensions? I'll do a PR if you'd allow that.
@SimonDanisch
Copy link
Member

Hm, I think I'd prefer HyperSphere{D}(radius)

@SimonDanisch
Copy link
Member

That would also compose nicely with the aliases for HyperSphere{D}, e.g. Circle(1), Sphere(1)

asinghvi17 added a commit that referenced this issue Dec 14, 2024
@asinghvi17
Fix #201
c4996fe
@asinghvi17 asinghvi17 linked a pull request Dec 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add methods for HyperSphere{N}(radius), HyperSphere{N, T}(radius) JuliaGeometry/GeometryBasics.jl
2 participants
@SimonDanisch @Datseris