Add Compat entries for extras #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the non-passing quality tests with Aqua by adding the necessary compat entries to Project.toml as suggested here.
For most cases, the requested version can be the latest version major version (they are compatible with julia 1.6 or less).
JET compat is a bit more tricky as it supports only limited versions and older JET versions might not work with the newest versions of Julia. I used a trick similar to what was proposed here to ensure the tests run against version 1.8 and locally for newer versions. Alternatively, the library could support more majour versions of JET.
I added a testset around Aqua and JET so all tests will run even if Aqua fails.