Skip to content

Commit

Permalink
add Aqua and adjust compats
Browse files Browse the repository at this point in the history
  • Loading branch information
sjkelly committed Jun 14, 2024
1 parent df38b65 commit a0b7026
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
10 changes: 9 additions & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,26 @@ uuid = "150eb455-5306-5404-9cee-2592286d6298"
version = "0.6.3"

[deps]
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"

This comment has been minimized.

Copy link
@timholy

timholy Sep 12, 2024

Member

@sjkelly This seems like a mistake? JET is a huge and fragile (to Julia version) dependency.

LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"

[compat]
Aqua = "0.8"
Documenter = "1"
ForwardDiff = "0.10"
LinearAlgebra = "1"
StaticArrays = "0.11, 0.12, 1.0"
Test = "1"
Unitful = "1"
julia = "1"

[extras]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"

[targets]
test = ["Test", "ForwardDiff", "Unitful", "Documenter"]
test = ["Test", "ForwardDiff", "Unitful", "Documenter", "Aqua"]
4 changes: 2 additions & 2 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ using ForwardDiff: Dual, partials
using StaticArrays
using Unitful
using Documenter: doctest

using Aqua

@testset "CoordinateTransformations" begin

Expand All @@ -14,5 +14,5 @@ using Documenter: doctest
include("coordinatesystems.jl")
include("affine.jl")
include("perspective.jl")

Aqua.test_all(CoordinateTransformations)
end

1 comment on commit a0b7026

@timholy
Copy link
Member

@timholy timholy commented on a0b7026 Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding [compat] bounds for stdlibs is a great idea in principle, but it broke tests on Julia 1.0. This really should have been submitted as a PR instead of pushing directly to master. Also xref #96.

Please sign in to comment.