Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for _normalizeindex with Base.OneTo #195

Merged

Conversation

charleskawczynski
Copy link
Contributor

This PR adds support for _normalizeindex with Base.OneTo for the second argument. In ClimaCoreTempestRemap.jl, we use axes on a struct which returns a Base.OneTo type, and it's failing with unsupported index.

@charleskawczynski
Copy link
Contributor Author

Hmm, I'm actually not sure whether this should be

_normalizeindex(n, ind::Base.OneTo) = 1:1:ind.stop

or

_normalizeindex(n, ind::Base.OneTo) = 1:1:n

@Alexander-Barth
Copy link
Member

Alexander-Barth commented Dec 9, 2022 via email

@Alexander-Barth
Copy link
Member

Thanks again!

@Alexander-Barth Alexander-Barth merged commit 95786f9 into JuliaGeo:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants