Skip to content

Commit

Permalink
Merge branch 'master' of github.com:Alexander-Barth/NCDatasets.jl
Browse files Browse the repository at this point in the history
  • Loading branch information
Alexander-Barth committed Oct 11, 2023
2 parents 981729f + 2729376 commit a8f2bcd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/variable.jl
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ end
nomissing(a::AbstractArray,value) = a
export nomissing

# This method needs to be duplicated instead of using an Union. Otherwise a DiskArrays fallback is called instead which impacts performances
# This method needs to be duplicated instead of using an Union. Otherwise a DiskArrays fallback is called instead which impacts performances
# (see https://github.com/Alexander-Barth/NCDatasets.jl/pull/205#issuecomment-1589575041)
function readblock!(v::Variable, aout, indexes::TI...) where TI <: Union{AbstractUnitRange,StepRange}
datamode(v.ds)
Expand Down Expand Up @@ -399,7 +399,7 @@ function _write_data_to_nc(v::Variable, data, indexes::Union{AbstractRange{<:Int
end

getchunksize(v::Variable) = getchunksize(haschunks(v),v)
getchunksize(::DiskArrays.Chunked, v::Variable) = chunking(v)[2]
getchunksize(::DiskArrays.Chunked, v::Variable) = Tuple(chunking(v)[2])
# getchunksize(::DiskArrays.Unchunked, v::Variable) = DiskArrays.estimate_chunksize(v)
getchunksize(::DiskArrays.Unchunked, v::Variable) = size(v)
eachchunk(v::CFVariable) = eachchunk(v.var)
Expand Down

0 comments on commit a8f2bcd

Please sign in to comment.