Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README example errors #4

Closed
joshday opened this issue Dec 14, 2022 · 0 comments · Fixed by #5
Closed

README example errors #4

joshday opened this issue Dec 14, 2022 · 0 comments · Fixed by #5

Comments

@joshday
Copy link
Contributor

joshday commented Dec 14, 2022

In the README example, the eltype of layers is a 1-element Vector{ArchGDAL.IGeometry{ArchGDAL.wkbMultiPolygon}}: so that GeoInterface.trait returns nothing. Maybe a change in ArchGDAL?

Leaflet.jl/src/map.jl

Lines 97 to 102 in 0b37561

function leaflet_javascript(layers, cfg::Config)
io = IOBuffer()
for (i, layer) in enumerate(layers)
data = layer.data
isnothing(GeoInterface.trait(data)) &&
throw(ArgumentError("data is not a GeoInterace compatible Feature or Geometry"))

joshday added a commit to joshday/Leaflet.jl that referenced this issue Dec 14, 2022
@joshday
Update README.md
1c2a72d 
Fixes JuliaGeo#4, but I'm not sure if this should actually be a downstream change instead in GADM or ArchGDAL
@joshday joshday mentioned this issue Dec 14, 2022
Merged
@rafaqz rafaqz closed this as completed in #5 Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update README.md joshday/Leaflet.jl
1 participant
@joshday