Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generator scripts 2 #122

Closed
wants to merge 5 commits into from
Closed

Conversation

melonedo
Copy link
Contributor

This commit adds macros and makes it work on Windows.

@melonedo
Copy link
Contributor Author

I generated in both linux and Windows, and I turns out time_t is different on the two platforms(Clong vs Clonglong).
Without more tests, I think the best choice might be using multi-platform configuration then.

cc @Gnimuc

@Gnimuc
Copy link

Gnimuc commented Aug 10, 2021

If time_t is the only one that is system-dependent, then using multi-platform is a bit overkill. I guess it's safe to define it as const time_t = Int in the prologue.jl.

@Gnimuc
Copy link

Gnimuc commented Aug 10, 2021

You could also take this as an example for manually adding definitions for different platforms: https://github.com/maleadt/LLVM.jl/blob/master/res/missing_defs.jl

@melonedo
Copy link
Contributor Author

Thanks! I will try it later.

@visr
Copy link
Member

visr commented Aug 10, 2021

Thanks for this! I cherry picked both commits into #121. The time_t workaround is also used there.

@visr visr closed this Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants