-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Massive update #90
Massive update #90
Conversation
@theogf I'm basically happy with this PR. Is there much else that you want to do, or are you keen to get it merged? |
There is still one issue I am trying to resolve (notice that test models-lgssm is failing). [EDIT:] It should be fixed now. |
Nevermind my fix was not a fix... The problem is that a |
Maybe we could merge the CompatHelper PRs as well before tagging the release? |
I already updated the bounds in this MR. The CompatHelper PRs can be closed once this is in. |
Ok I found the issue. I partially fixed it by calling |
The new error comes from a change in |
This is an issue that has to do with |
I had to remove the tests for the invariant LGSSM, I will add an issue to add them back. |
Pull Request Test Coverage Report for Build 4480292273Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving in order to get out of your way @theogf , as it looks like this is in a good place now
This:
This PR does not solve the type instabilities and allocations arising from the updates of other packages. These performance problems will be moved into issues of their own to be tackled separately while the rest of the package can be updated and improved.
News!
This ended up being bigger than all of us.
So updated things were:
adjoint_test
withtest_rrule
(with some additional syntax wrappers)@adjoint
withrrule
sAbstractGPs
interface (mostly change of order of parameters)The bad things were:
runtests.jl
TODO
and I plan to open Github issues to resolve them