Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address type piracy compilation failures (fix #120) #121

Closed
wants to merge 1 commit into from

Conversation

sefffal
Copy link

@sefffal sefffal commented Dec 21, 2023

This PR just removes some apparently unneeded diff rules that pirated static arrays.
Running ]test TemporalGPs passes after removing these lines.

@sefffal
Copy link
Author

sefffal commented Dec 21, 2023

cc @willtebbutt

@sefffal
Copy link
Author

sefffal commented Apr 3, 2024

Hi all, I know there is work on a migration to Enzyme, but in the meantime could we look at merging this PR or similar? I'm still getting compilation errors in OctofitterRadialVelocity on 1.10 due to this issue.

Thanks for your help!

@willtebbutt willtebbutt closed this Apr 3, 2024
@willtebbutt willtebbutt reopened this Apr 3, 2024
@willtebbutt
Copy link
Member

Hi @sefffal -- sorry for dropping this. I'm just running CI again to see if the tests start passing. I'm happy to merge if they do, and to assist debugging if they don't. I agree that it would be good to get this sorted.

@sefffal
Copy link
Author

sefffal commented Apr 3, 2024

@willtebbutt thanks so much! It's no problem, I have a mountain of OSS issues to tackle myself ;)

It looks like my changes were a little over broad and causing failures, we might need to be more surgical and just remove the one offending method.

@willtebbutt
Copy link
Member

Closing as this is now outdated. Please feel free to re-open if you feel there's more to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants