Add support for nothing
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have been using this quite often to conditionally drop specific parameters.
simsurace
commented
Feb 5, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
I can't see anything to be concerned about -- I can definitely get behind this. I'm happy to approve once you've added the test cases that you mention, and bumped the batch version. |
willtebbutt
approved these changes
Feb 6, 2024
|
Do you merge rights @simsurace ? |
|
BTW, why is CI not running? |
|
Ooooo I did not twig that that had no happened. I'll check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been using this quite often to conditionally drop specific parameters, and I'm considering using it in a public package. Since it is piracy to define it elsewhere, I would kindly ask to consider adding this here. I will add a test if this doesn't raise any fundamental concerns.