-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax orthogonal #53
Relax orthogonal #53
Conversation
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 96.80% 96.80%
=======================================
Files 7 7
Lines 188 188
=======================================
Hits 182 182
Misses 6 6
Continue to review full report at Codecov.
|
I didn't include any test changes here as it's just a relaxation, would add a test-dep, and covered by existing. But the example code in the description can easily be converted into them. |
@@ -46,7 +46,7 @@ be a positive-definite matrix (see https://en.wikipedia.org/wiki/Definite_matrix | |||
|
|||
The unconstrained parameter is a `LowerTriangular` matrix, stored as a vector. | |||
""" | |||
function positive_definite(X::StridedMatrix{<:Real}) | |||
function positive_definite(X::AbstractMatrix{<:Real}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The motivation was orthogonal but I included this too
Yeah, based on what the functions are doing I don't see a strong reason to restrict the type. I'd appreciate @willtebbutt's input on this though given #22. Don't forget to update the docstrings. |
One issue with this I've found recently revisiting
orthogonal
is that it restricts wrapper arrays. As an example, present internal pipelines useAxisKeys
andNamedDims
- however theStridedArray
restriction prevents this:Rewriting orthgonal to allow for abstractmatrix allows this to work:
With a nod to #22 AFAICT only
flatten
needs to be specialised?