Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Compat to 4, (keep existing compat) #52

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Compat package from 3 to 3, 4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@rofinn rofinn force-pushed the compathelper/new_version/2022-05-24-00-08-12-702-01996045878 branch from ceb0426 to 23c4d35 Compare May 24, 2022 00:08
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #52 (0ef4973) into master (dd13a55) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files           8        8           
  Lines         222      222           
=======================================
  Hits          216      216           
  Misses          6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@simsurace
Copy link
Member

Could someone re-run the CI and possibly merge this (I saw no failures locally)? This is holding back having the most recent version of DataFrames installed in the same environment.

@willtebbutt willtebbutt merged commit 3911fb9 into master Oct 17, 2022
@willtebbutt willtebbutt deleted the compathelper/new_version/2022-05-24-00-08-12-702-01996045878 branch October 17, 2022 10:25
@willtebbutt
Copy link
Member

Thanks for commenting on this @simsurace -- should be available on the general registry shortly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants