split parameters.jl into smaller files #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 96.80% 96.55% -0.26%
==========================================
Files 4 7 +3
Lines 188 174 -14
==========================================
- Hits 182 168 -14
Misses 6 6
Continue to review full report at Codecov.
|
|
@willtebbutt would you be happy to accept this in principle? then I'll go through and sort out the merge conflict.... |
|
Sorry for the slow response @st-- . I like this PR, would be happy to merge it once merge conflicts have been resolved. |
|
@willtebbutt done, ready for review! |
willtebbutt
approved these changes
Nov 27, 2021
|
I literally just moved code around - I even kept the order... Not really
something that needs to be pushed downstream right away, no? Can you not
just merge it as is, by the time I'm next on my laptop I'll have forgotten
and then before you know it there's a merge conflict with some new pr..
On Saturday, November 27, 2021, willtebbutt ***@***.***> wrote:
@willtebbutt approved this pull request.
LGTM. Please could you bump the patch (I know this is meant to be a
zero-modifcation PR, but just in case something has been missed), then I'll
merge + tag.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android. <
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #44. Once we've agreed with the structure proposed in this PR, I'll also update the test/ structure to match.