Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docs for when docs site is up and improving readme #36

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thomasgudjonwright
Copy link
Member

Starting to improve documentation.

docs/make.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #36 (2df7f2c) into master (04ab945) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          158       158           
=========================================
  Hits           158       158           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ab945...2df7f2c. Read the comment docs.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/make.jl Outdated
pages=[
"Home" => "index.md",
],
pages=["Home" => "index.md", "API" => "api.md",],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
pages=["Home" => "index.md", "API" => "api.md",],
pages=["Home" => "index.md", "API" => "api.md"],

@thomasgudjonwright
Copy link
Member Author

LGTM

Is it obvious to you why the docs are breaking? Is it maybe since the doc site isn't fully set up yet? I wouldn't think that would mean we can't have an api.md set up as we do for when its ready.

@willtebbutt
Copy link
Member

I think it might be that, because strict=true, documenter build fails if any warnings are thrown. strict=true is probably good, so we should resolve the warnings.

My suspision is that autodocs is producing a million docstrings for all of the methods of rand etc. You could try building the docs locally with strict=false to see if something is going obviously wrong?

@thomasgudjonwright
Copy link
Member Author

I think it might be that, because strict=true, documenter build fails if any warnings are thrown. strict=true is probably good, so we should resolve the warnings.

My suspision is that autodocs is producing a million docstrings for all of the methods of rand etc. You could try building the docs locally with strict=false to see if something is going obviously wrong?

Bingo, it ran with that change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants