-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve Float type for Periodic Kernel #560
Preserve Float type for Periodic Kernel #560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, can you add a test for the fix?
Certainly, it's been added. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
===========================================
+ Coverage 0.42% 16.29% +15.87%
===========================================
Files 52 52
Lines 1423 1430 +7
===========================================
+ Hits 6 233 +227
+ Misses 1417 1197 -220 ☔ View full report in Codecov by Sentry. |
Co-authored-by: David Widmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The changes that you've made do not appear to have anything to do with the test failures, so I'm going to merge. |
ab866b9
into
JuliaGaussianProcesses:master
Summary
Tiny change to preserve float type of inputs and parameters. For most of the kernels, if the inputs and parameters have Float32 type, then the output has also Float32:
However, currently,
PeriodicKernel
doesn't support this:The simple change of
exp(-0.5d)
toexp(-d / 2)
in itskappa
function fixes it: