Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Symmetric(::Diagonal) type piracy #115

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Remove Symmetric(::Diagonal) type piracy #115

merged 1 commit into from
Mar 29, 2021

Conversation

devmotion
Copy link
Member

As the name says, this removes some pretty severe type piracy. Instead I switched to _symmetric wherever it seems possible to operate with diagonal matrices, and moved the helper functions _symmetric and _cholesky and their tests to the src/util folder.

willtebbutt
willtebbutt approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this -- infinitely better than before.

@devmotion devmotion merged commit fbc0213 into master Mar 29, 2021
@devmotion devmotion deleted the dw/symmetric branch March 29, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willtebbutt willtebbutt willtebbutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devmotion @willtebbutt