This repository has been archived by the owner on Mar 12, 2021. It is now read-only.
RNN Failure hackaround #515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are still allocating the reserve after that, which might change the heuristic again. I have a cleaner prototype hackaround, let me push that here in a minute. |
|
Ok, closing this for now so we can see your version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See FluxML/Flux.jl#923. Right now, just testing this to confirm if it fixes the original issue. A nasty fix but hopefully this shows up infrequently enough that it's OK.
TODO unsafe_free the unused workspaces.