This repository has been archived by the owner on Mar 12, 2021. It is now read-only.
Dup of nnlib_overhaul [DO NOT MERGE] #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
|
Sorry, I broke CI trying to update some scripts for the upcoming JuliaRegistrator... |
tryBuild failed |
|
Never apologize, never surrender |
|
CI should be fixed, if you rebase again it should work. |
Also implement some compatibility shims so that client code may not have to adjust just yet
Also implement some compatibility shims so that client code may not have to adjust just yet
kshyatt
force-pushed
the
sf/nnlib_overhaul
branch
from
522e1a3 to
cf07897
Compare
|
bors try |
tryBuild succeeded |
So tempting... |
|
If FluxML/NNlib.jl#94 lands, be sure to add NNlib 0.6 compatibility to Project.toml before merging this. |
|
It's landed. |
|
Thanks so much @kshyatt! I'm going to close mine in favor of this. I don't really know how to add compatibility bounds either. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 5, 2019
315: Dup of nnlib_overhaul [DO NOT MERGE] r=maleadt a=kshyatt opened a new PR to test the rebased on top of master version without corrupting Elliot's PR. Co-authored-by: Elliot Saba <[email protected]> Co-authored-by: Katharine Hyatt <[email protected]> Co-authored-by: Tim Besard <[email protected]>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opened a new PR to test the rebased on top of master version without corrupting Elliot's PR.