This repository has been archived by the owner on May 27, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23a0c07
to
5d8dcca
Compare
5d8dcca
to
b6e31f1
Compare
Is the non-recursive codegen still going to happen prior to 0.7/1.0? |
Probably not. The scope of the upstream issue is much broader, and AFAIK Jameson isn't happy with the design yet. |
b52784c
to
f253041
Compare
26686a4
to
8b6dde9
Compare
be7dbe4
to
830f144
Compare
6ccb6b3
to
24c3cf7
Compare
caf8483
to
51ded70
Compare
b6e31f1
to
7f58c70
Compare
Updated for JuliaLang/julia@2cd11c4; works pretty well but need to figure out how to deal with LLVM's contexts. There's an accessor ( |
7f58c70
to
6c3feb4
Compare
17dfd92
to
3c9b279
Compare
0ecfa88
to
289489c
Compare
Looks like the new codegen broak float16 multiplication:
Whereas on 1.3: ; @ float.jl:398 within `*'
define i16 @julia___29(i16, i16) {
top:
%2 = call float @julia_Float32_17988(i16 %0)
%3 = call float @julia_Float32_17988(i16 %1)
; @ float.jl:209 within `Float32'
define internal float @julia_Float32_17988(i16) {
top:
; normal code
|
34dc9b4
to
daecaf0
Compare
daecaf0
to
9447747
Compare
9447747
to
5bef492
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs JuliaLang/julia#25984, with additional changes from JuliaLang/julia@jn/codegen-norecursion...tb/codegen-norecursion