Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUSOLVER improvements #1194

Closed
wants to merge 5 commits into from
Closed

CUSOLVER improvements #1194

wants to merge 5 commits into from

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Oct 7, 2021

Adds ldiv! for QR from #1192, and implements lu fixing #1193.
cc @ChrisRackauckas

@maleadt maleadt added enhancement New feature or request cuda libraries Stuff about CUDA library wrappers. labels Oct 7, 2021
@ChrisRackauckas
Copy link
Member

What about the ldiv! overloads for LU? Will those work as well?

@maleadt maleadt marked this pull request as draft October 7, 2021 13:43
@maleadt
Copy link
Member Author

maleadt commented Oct 7, 2021

Not straight away. Looking into this, we'll have to duplicate all of LinearAlgebra.LU again into a CUDA-specific CUDA.CuLU, just like we had to do for LinearAlgebra.QR...

@andreasnoack would it be possible (without requiring a Julia 2.0-type API break) to make the Factorization classes GPU compatible using additional typevars for the pivot indices/coefficients/...? Those are currently all hard-coded to Array, which breaks GPU compatibility.

@andreasnoack
Copy link
Member

It's a shame that we didn't finish that process before the Julia 1.0 release. Unfortunately, I'm not sure we'd be able to make that change without breaking things. We could try it and run PkgEval but I'd think that we'd see several errors. I have a vague memory of similar changes resulting in downstream failures in the past.

@maleadt
Copy link
Member Author

maleadt commented Mar 22, 2022

Part of #1449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda libraries Stuff about CUDA library wrappers. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants