Argument names and types in API functions #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that currently all low-level functions (e.g.
clblasSaxpy
) have neither names, nor types of variables, e.g.:which makes it pretty hard to inspect and call such functions. This PR is an attempt to provide new low-level API with all the same functionality, but improved function signatures, e.g.:
Here's is a lost of planned tasks that I'm going to follow if nobody has objections/suggestions:
@blasfun
and@blasfun2
similar to@blas_func
and@blas_func
, but with argument names and typesThe next step (probably, as a separate PR) will be to create high-level API, wrapping this one and using
cl.CLArray
instead of plain buffers.Discussion is welcome.