Fix GLbyte definition for aarch64 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ const GLdouble = Cdouble | |||
| const GLushort = Cushort | |||
| const GLuint = Cuint | |||
| const GLint64 = Clonglong | |||
| const GLbyte = Cchar | |||
| const GLbyte = Int8 | |||
There was a problem hiding this comment.
Perhaps worth adding a comment to guard against regression given this doesn't have test coverage as CI isn't run on aarch64?
Suggested change
| const GLbyte = Int8 | |
| const GLbyte = Int8 # Cannot be a Cchar as Cchar is unsigned on aarch64 |
There was a problem hiding this comment.
well, I'm not really sure why we initially used Cchar here, so there is a big chance, that it was just completely wrong...
So I don't think we actually need to motivate that we don't use Cchar anymore.
See the new Clang wrapped constants, that use the OpenGL headers as the source of trueth:
Line 15 in 4740d6e
Line 1101 in 4740d6e
Which does seem to prove, that Cchar was simply just wrongly translated early on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MakieOrg/Makie.jl#1616 and #39