Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs #73

Merged
merged 6 commits into from
Jan 25, 2022
Merged

Fix bugs #73

merged 6 commits into from
Jan 25, 2022

Conversation

heyx3
Copy link
Contributor

@heyx3 heyx3 commented Jan 25, 2022

My other branch had too much stuff going on, sorry about that.

I made this branch to focus on the important and simpler problems, with missing constants and the bugged GLsizei.

@heyx3
Copy link
Contributor Author

heyx3 commented Jan 25, 2022

Reposting what I mentioned in the previous PR about GLsizei, for reference:

The errors I saw related to GLsizei being 64-bit instead of 32-bit was that any time i passed in a pointer to GLsizei, for OpenGL to tell me the length of something (e.x. a uniform name string, or an error log string), it would sometimes return a ridiculously large size, on the order of hundreds of billions.

It was extremely infrequent when getting uniform names, but happened every time when trying to read the error log. And it hasn't happened since changing the definition of GLsizei.

@SimonDanisch
Copy link
Member

Thank you!

@SimonDanisch SimonDanisch merged commit a826ef8 into JuliaGL:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants