Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CI to GH actions #64

Merged
merged 2 commits into from
May 1, 2021
Merged

Switch CI to GH actions #64

merged 2 commits into from
May 1, 2021

Conversation

musm
Copy link
Contributor

@musm musm commented Apr 28, 2021

  • Update CI to gh actions
  • Install RegisterAction gh action
  • Update LICENSE to format GitHub prefers
  • Use Sys.isplatform instead of const redefinitions.

@musm musm force-pushed the up branch 5 times, most recently from aa7abe1 to 701b0d6 Compare April 28, 2021 20:34
@musm musm requested a review from SimonDanisch April 28, 2021 20:37
@musm
Copy link
Contributor Author

musm commented Apr 29, 2021

Squashed and ready on my end

@musm
Copy link
Contributor Author

musm commented Apr 30, 2021

@SimonDanisch any chance you could review this PR?

@SimonDanisch
Copy link
Member

Thanks this is great :)

I'm not 100% sure, I want to introduce the cost of the runtime check of the debug value for all ModernGL functions without any ability to turn it off...
Any chance we can benchmark this?

@musm
Copy link
Contributor Author

musm commented Apr 30, 2021

Fair point! Added back the compile time for the debug value

@musm musm changed the title Overhaul CI, format License, debug env check Switch CI to GH actions Apr 30, 2021
@SimonDanisch
Copy link
Member

Thanks ;)

@SimonDanisch SimonDanisch merged commit 99af1a8 into JuliaGL:master May 1, 2021
@musm musm deleted the up branch May 1, 2021 15:21
@musm
Copy link
Contributor Author

musm commented May 2, 2021

Many thanks. Could you also delete https://ci.appveyor.com/project/SimonDanisch/moderngl-jl ?

@SimonDanisch
Copy link
Member

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants