error instead of warning #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to get the full stacktrace
asinghvi17
reviewed
Mar 14, 2020
| @@ -19,7 +19,7 @@ function debug_opengl_expr(func_name, args) | |||
| err = glGetError() | |||
| if err != GL_NO_ERROR | |||
| arguments = gl_represent.(tuple($(args...))) | |||
| @warn("OpenGL call to $($func_name), with arguments: $(arguments) | |||
| error("OpenGL call to $($func_name), with arguments: $(arguments) | |||
There was a problem hiding this comment.
Suggested change
| error("OpenGL call to $($func_name), with arguments: $(arguments) | |
| @error("OpenGL call to $($func_name), with arguments: $(arguments) |
you need the macro for the stacktrace, I think
There was a problem hiding this comment.
No this just interrupts
There was a problem hiding this comment.
So you get an error & stacktrace
|
Seems logical to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to get the full stacktrace