Ensemble-problem compatible update #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to only use the new return error codes instead of keeping the old stuff for backwards compatibility |
|
Let me know if you are happy with this and I'll go ahead and merge it. |
|
Hi Luke and Henrik, thanks for this. I'll wait to ask you to merge until I've finished working on the orbit tomography package, in case I make any more changes to this one:) |
|
Sounds good! Just let us know when it's all ready. I would like to review OrbitTomography.jl further, but I consider GuidingCenterOrbits.jl ready for merge whenever now. |
|
I am ready to approve. @lstagner could you take one quick look-through as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.