Some tweaks to the @tasks macro
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carstenbauer
approved these changes
Mar 1, 2024
|
I like it. I think we're ready to merge both PRs. |
MasonProtter
added a commit
that referenced
this pull request
Mar 1, 2024
* try implement threaded macro * fix conflict * reduce -> reducer; support begin end block for tasklocal macro * wrap in let block * Update src/macro.jl Co-authored-by: Mason Protter <[email protected]> * rename macros * add support for settings block * hygiene * fix conflict * only take setting through set macro, i.e. drop keyword arguments * comment out unused code * some tests * improve tests a little bit * add collect=true -> tmap option + more tests * tmp * fix conflict * basic docstring * docstring changes * add macro api examples to docs * include tasks macro example in tls * add bumper to tls doc page * change comment * docsstrings for set and init + README * minor * adjust changelog (bump version number) * Some tweaks to the `@tasks` macro (#62) * move macro body to the internals module * only accept one argument, error if the user gives a complex loop assignemnt * remove double quoting, reformat comment * remove outdated code * re-org --------- Co-authored-by: Mason Protter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @carstenbauer, some of these would have been annoying to do in the code review section so I figured I'd just do it in a PR to your PR. Very meta.
Summary of suggested changes here, feel free to reject any of them:
Implementationmodule so they don't appear as public API.@tasksonly accepts a single argument. Not zero or1arguments@taskswill error if the users types things like(before it macroexpanded to something that'd throw a confusing syntax error during lowering)
@initthings inserted code like(OhMyThreads.OhMyThreads).TaskLocalValue{T}((()->...into the AST, so I made it instead doOhMyThreads.TaskLocalValue{T}((()->....Other than these minor things, this looks fantastic. Thanks for taking it on!