Skip to content

Commit

Permalink
Fix bench_gemm.jl performance regression
Browse files Browse the repository at this point in the history
The type parameter of `BottomRF` was changed so `BottomRF{Any}`
creates a boxed type.
  • Loading branch information
tkf committed Aug 19, 2019
1 parent 36f8211 commit 3f52689
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion benchmark/bench_gemm.jl
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function xfmul!(C, A, B, simd=Val(false))
c[] = muladd(a, b, c[])
return # for type stability
end
transduce(maybe_usesimd(BottomRF{Any}(rf), simd), nothing, CAB)
transduce(maybe_usesimd(BottomRF(rf), simd), nothing, CAB)

return C
end
Expand Down
3 changes: 1 addition & 2 deletions src/processes.jl
Original file line number Diff line number Diff line change
Expand Up @@ -929,8 +929,7 @@ Base.foreach(eff, ed::Eduction; kwargs...) =
transduce(reform(ed.rf, SideEffect(eff)), nothing, ed.coll;
kwargs...)
Base.foreach(eff, reducible::Reducible; kwargs...) =
transduce(BottomRF{Any}(SideEffect(eff)), nothing, reducible;
kwargs...)
transduce(BottomRF(SideEffect(eff)), nothing, reducible; kwargs...)
# Maybe use `__reduce__` in `foreach`?

"""
Expand Down

0 comments on commit 3f52689

Please sign in to comment.