fix == on Reductions (#545)

JuliaFolds · Nov 27, 2022 · 142abcb · 142abcb
1 parent bd958e4
commit 142abcb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/core.jl b/src/core.jl
@@ -319,6 +319,8 @@ struct Reduction{X <: Transducer, I} <: AbstractReduction{I}
         end
 end
 
+Base.:(==)(r1::Reduction, r2::Reduction) = (r1.xform == r2.xform) && (r1.inner == r2.inner)
+
 if VERSION < v"1.3"  # pre https://github.com/JuliaLang/julia/pull/31916
     @inline (rf::Reduction)(state, input) = next(rf, state, input)
 end

diff --git a/test/test_show.jl b/test/test_show.jl
@@ -77,15 +77,8 @@ end
         $code
         """
         VERSION < v"1.5-beta" && occursin("⨟", code) && continue
-        xf isa GetIndex && continue
         rf2 = include_string(@__MODULE__, code)
-        if xf isa GetIndex
-            # This is casued by Base.:(==)(::AbstractReduction, ::AbstractReduction) falling back on ===
-            # https://github.com/JuliaFolds/Transducers.jl/issues/540
-            @test_broken rf == rf2
-        else
-            @test rf == rf2
-        end 
+        @test rf == rf2
     end
 end
-Original file line number
+Diff line change
@@ Expand Up @@
             end
     end
+    Base.:(==)(r1::Reduction, r2::Reduction) = (r1.xform == r2.xform) && (r1.inner == r2.inner)
     if VERSION < v"1.3"  # pre https://github.com/JuliaLang/julia/pull/31916
         @inline (rf::Reduction)(state, input) = next(rf, state, input)
     end
@@ Expand Down @@