-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce allocations in PANOC, PANOCplus, ZeroFPR, DRLS #74
Conversation
dc3b738
to
9be1b01
Compare
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 88.93% 89.21% +0.27%
==========================================
Files 21 21
Lines 886 909 +23
==========================================
+ Hits 788 811 +23
Misses 98 98
Continue to review full report at Codecov.
|
Allocations went down in benchmarks, as expected. However, there is a strange increase in allocations for DRLS, so I'll need to look deeper into it. Time increases are probably just noise.
|
@aldma could you please confirm the changes in PANOCplus are OK? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The overwriting of x_prev
and res_prev
works because update_direction_state!
is invoked only once just before returning.
8284812
to
43a515e
Compare
No description provided.