Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos, update constructors, add Chambolle-Pock constructor #61

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

lostella
Copy link
Member

@lostella lostella commented Jan 21, 2022

cc @pylat

Main changes:

  • raise an error in case Lipschitz constants are not given (but the corresponding terms are)
  • add constructor for Chambolle-Pock (it's a very famous algorithm, there should be a direct way to instantiate it, even if it’s just a special case of Vu-Condat)
  • refactor a little the default stepsize computation
  • fix typos in the docstrings

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #61 (0fd3ad2) into master (ee31033) will decrease coverage by 0.05%.
The diff coverage is 48.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   89.39%   89.33%   -0.06%     
==========================================
  Files          22       22              
  Lines         962      966       +4     
==========================================
+ Hits          860      863       +3     
- Misses        102      103       +1     
Impacted Files Coverage Δ
src/algorithms/primal_dual.jl 63.93% <48.57%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee31033...0fd3ad2. Read the comment docs.

@lostella lostella requested a review from pylat January 25, 2022 09:04
@lostella
Copy link
Member Author

@pylat do you have any concern with this? If not, I’ll merge it and move on with other changes I have in the pipeline

@lostella
Copy link
Member Author

(Merging: I will address any comment or concern later on)

@lostella lostella merged commit 3cd2cca into JuliaFirstOrder:master Jan 28, 2022
@lostella lostella deleted the improve-primal-dual branch January 28, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant