Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in line search in DRLS #53

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Conversation

lostella
Copy link
Member

@lostella lostella commented Oct 21, 2021

The check

if DRE_candidate <= DRE_curr - iter.c / iter.gamma * norm(state.res)^2

should be

if DRE_candidate <= DRE_curr - iter.c / iter.gamma * norm(state.res_prev)^2

Other code improvements are included.

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #53 (9ce5452) into master (96fd0c2) will increase coverage by 0.01%.
The diff coverage is 92.85%.

❗ Current head 9ce5452 differs from pull request most recent head 5aeabe5. Consider uploading reports for the commit 5aeabe5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   88.38%   88.40%   +0.01%     
==========================================
  Files          20       20              
  Lines         801      802       +1     
==========================================
+ Hits          708      709       +1     
  Misses         93       93              
Impacted Files Coverage Δ
src/algorithms/drls.jl 91.37% <92.85%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96fd0c2...5aeabe5. Read the comment docs.

@lostella lostella merged commit b89725b into JuliaFirstOrder:master Oct 21, 2021
@lostella lostella deleted the fix-drls branch October 21, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant