Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark #49

Merged
merged 3 commits into from
Sep 20, 2021
Merged

Conversation

lostella
Copy link
Member

@lostella lostella commented Sep 20, 2021

  • Add missing dependency
  • Fix bug in benchmark problem

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #49 (52886d1) into master (28f3cfc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   87.96%   87.96%           
=======================================
  Files          18       18           
  Lines         748      748           
=======================================
  Hits          658      658           
  Misses         90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28f3cfc...52886d1. Read the comment docs.

@lostella lostella changed the title Fix benchmark environment Fix benchmark Sep 20, 2021
@lostella
Copy link
Member Author

Benchmark workflow is failing due to missing dependency in master. Running fine with the code in this PR; merging.

@lostella lostella merged commit 2f5d17d into JuliaFirstOrder:master Sep 20, 2021
@lostella lostella deleted the fix-benchmark-env branch September 20, 2021 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant