-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce algorithms boilerplate #47
Reduce algorithms boilerplate #47
Conversation
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 87.15% 87.96% +0.80%
==========================================
Files 18 18
Lines 841 748 -93
==========================================
- Hits 733 658 -75
+ Misses 108 90 -18
Continue to review full report at Codecov.
|
Very interesting macro. (Not to be found in the manual!) It looks good to me. Thanks Stella. |
This is a breaking change, mainly aiming at significantly reducing the boilerplate around algorithms (500+ lines are gone from the algorithms implementations), and making the iterable types more usable directly, by having docstrings and default parameters.
Please refer to the changes in tests to get a feeling for the level of breakage (but not everything is covered there).
Most relevant changes:
<AlgorithmName>Iteration
Base.@kwdef
macro0.5.0
because of the breaking changesBase.@kwdef
)