fixing the node docs

[timziebart]

Hi @SabineAuer ,

could you please fix the docs of the nodes that you implemented. You can locally check the results by running make docs (in the PowerDynamics.jl folder) and the result will be in PowerDynamics.jl/docs/build/index.html.

• https://juliaenergy.github.io/PowerDynamics.jl/stable/node_types.html#PowerDynBase.FourthEq
• https://juliaenergy.github.io/PowerDynamics.jl/stable/node_types.html#PowerDynBase.VSIMinimal
• https://juliaenergy.github.io/PowerDynamics.jl/stable/node_types.html#PowerDynBase.VSIVoltagePT1

[SabineAuer]

I fixed the docs, committed and pushed my changes to branch master (see commit). Can I close this issue now?

[timziebart]

Please do not push directly to master. Always open a PR, so we can discuss the content before it goes to master. That keeps master working and ensures we don't have a cluttered history.

Hence, please

1. undo the commit on master (on github)
2. open a PR with your suggested changes
3. let's discuss it in the PR then.

[SabineAuer]

Can we also close this issue now?

[timziebart]

Only the docs of FourthEq are fixed. The others are still broken:
https://juliaenergy.github.io/PowerDynamics.jl/dev/node_types/#PowerDynBase.VSIMinimal
https://juliaenergy.github.io/PowerDynamics.jl/dev/node_types/#PowerDynBase.VSIVoltagePT1

[SabineAuer]

@timkittel: Can you help me out what exactly you refer to? :)

[timziebart]

They both have the paragraph on ω being a rotor frequency (and there is no rotor) and they miss a reference (if possible a standard book, not a paper).