-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to use RegistryInstances #68
Conversation
This should also fix the CI failures on main, I believe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but tests are failing, haven't seen why.
This should fix #67, right?
Ok, now CI is passing but docs are failing:
I can regen a documenter key and add it as a secret, but it seems weird it is failing |
There's no deploy key: https://github.com/JuliaEcosystem/PackageAnalyzer.jl/settings/keys. I've had a few cases like this lately, some old keys disappeared. |
I will merge, but I think we before we register v1.0 we may want to swap out |
That's OK with me! |
This allows us to work with compressed registries, and also offloads some of the parsing and path manipulation there.
I bumped it as a breaking release because we had documented
RegistryEntry
's as a way to use PackageAnalyzer, and this drops support for them in favor of RegistryInstance's PkgEntry object.