Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use RegistryInstances #68

Merged
merged 4 commits into from
Oct 1, 2022
Merged

Conversation

ericphanson
Copy link
Member

This allows us to work with compressed registries, and also offloads some of the parsing and path manipulation there.

I bumped it as a breaking release because we had documented RegistryEntry's as a way to use PackageAnalyzer, and this drops support for them in favor of RegistryInstance's PkgEntry object.

@ericphanson ericphanson requested a review from giordano October 1, 2022 14:40
@ericphanson
Copy link
Member Author

This should also fix the CI failures on main, I believe

Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but tests are failing, haven't seen why.

This should fix #67, right?

Project.toml Outdated Show resolved Hide resolved
Project.toml Show resolved Hide resolved
test/runtests.jl Show resolved Hide resolved
@ericphanson ericphanson linked an issue Oct 1, 2022 that may be closed by this pull request
@ericphanson
Copy link
Member Author

Ok, now CI is passing but docs are failing:

Failed to add the ECDSA host key for IP address '140.82.114.3' to the list of known hosts (/home/runner/.ssh/known_hosts).
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
┌ Error: Git failed to fetch [email protected]:JuliaEcosystem/PackageAnalyzer.jl.git
│ This can be caused by a DOCUMENTER_KEY variable that is not correctly set up.
│ Make sure that the environment variable is properly set up as a Base64-encoded string
│ of the SSH private key. You may need to re-generate the keys with DocumenterTools.
└ @ Documenter ~/.julia/packages/Documenter/yf96B/src/Documenter.jl:652
┌ Error: Failed to push:
│ exception =
│ failed process: Process(setenv(/usr/bin/git fetch upstream,["DOCUMENTER_KEY=***", "PATH=/opt/hostedtoolcache/julia/1.6.7/x64/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin", "DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1", "GITHUB_RUN_NUMBER=149", "GITHUB_REF_NAME=68/merge", "RUNNER_ARCH=X64", "PERFLOG_LOCATION_SETTING=RUNNER_PERFLOG", "ACCEPT_EULA=Y", "ANT_HOME=/usr/share/ant", "RUNNER_USER=runner" … "JAVA_HOME_11_X64=/usr/lib/jvm/temurin-11-jdk-amd64", "SELENIUM_JAR_PATH=/usr/share/java/selenium-server.jar", "GITHUB_TRIGGERING_ACTOR=ericphanson", "GITHUB_REPOSITORY_OWNER=JuliaEcosystem", "RUNNER_TEMP=/home/runner/work/_temp", "DOTNET_NOLOGO=1", "GITHUB_EVENT_NAME=pull_request", "OPENBLAS_MAIN_FREE=1", "ANDROID_NDK_HOME=/usr/local/lib/android/sdk/ndk/25.1.8937393", "AGENT_TOOLSDIRECTORY=/opt/hostedtoolcache"]), ProcessExited(128)) [128]

I can regen a documenter key and add it as a secret, but it seems weird it is failing

@giordano
Copy link
Member

giordano commented Oct 1, 2022

There's no deploy key: https://github.com/JuliaEcosystem/PackageAnalyzer.jl/settings/keys. I've had a few cases like this lately, some old keys disappeared.

@ericphanson
Copy link
Member Author

I will merge, but I think we before we register v1.0 we may want to swap out registry=general_registry() for registries=reachable_registries() to support looking up packages from multiple registries off the bat

@ericphanson ericphanson merged commit a7e095a into main Oct 1, 2022
@ericphanson ericphanson deleted the eph/registry_instances branch October 1, 2022 15:44
@giordano
Copy link
Member

giordano commented Oct 1, 2022

That's OK with me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deal with compressed registry in Julia v1.7
2 participants