-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for CSV to 0.9, (keep existing compat) #550
CompatHelper: bump compat for CSV to 0.9, (keep existing compat) #550
Conversation
Tests fail on 0.9.
|
Interesting. I'll take a look |
This PR: JuliaData/CSV.jl#870 Seems to be the cause of this. CSV.jl now validates the |
Think we'd be fine if we need to move to 0.9 as our base and drop support for 0.8 if you can't see an easy solution. |
It's the other way around. That PR was merged in 0.9, so the current setup only works with 0.8. |
I can't find a way to do this with 0.9. I'll open an issue in CSV.jl, since this seems like something that should be optional. |
I passed |
This looks like it specifically happens when the type of a column is inferred to be
If the type of for r in CSV.Rows(read("test/test.csv"); types = Dict(:id => Int, :pos_1 => Int, :pos_2 => Int, :pos_3 => Int, :has_prisoner => Bool, :capture_time => Int, :shape => String))
print(r)
end doesn't work: for r in CSV.Rows(read("test/test.csv"); types = Dict(:id => Int, :pos_1 => Int, :pos_2 => Int, :pos_3 => Int, :has_prisoner => Bool, :capture_time => Int, :shape => Symbol))
print(r)
end The same error does not occur for |
Tests pass locally now, I'm not sure how to get it to rerun CI here without pushing a couple fake commits (comment-uncomment a line) EDIT: Found it :) |
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 24 24
Lines 1457 1457
=======================================
Hits 1375 1375
Misses 82 82
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AayushSabharwal feel free to merge here.
Oh, but first please bump the CSV version to its appripriate one (I think 0.9.6?) |
This pull request changes the compat entry for the
CSV
package from0.8
to0.8, 0.9
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.