Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is detectwsl() defined? #155

Closed
kdheepak opened this issue Feb 16, 2023 · 5 comments · Fixed by #156
Closed

Where is detectwsl() defined? #155

kdheepak opened this issue Feb 16, 2023 · 5 comments · Fixed by #156
Labels
bug Something isn't working

Comments

@kdheepak
Copy link

I'm not able to find detechwsl() anywhere.

image

Is this function defined in another package?

@kdheepak
Copy link
Author

It looks like it was a PR made to Julia in JuliaLang/julia#36425 but I'm not able to access the function:

image

I'm also not able to see the function any more in the base/sysinfo.jl file:

image

@kdheepak
Copy link
Author

It looks like this PR is not merged yet. Wouldn't this throw an error if it hit that condition?

@tlienart
Copy link
Collaborator

tlienart commented Feb 16, 2023

Ping @Roger-luo who wrote this bit. Indeed that bit || detectwsl() should be dropped.

It's in a try block though so no error is shown, just no browser started I guess.

@tlienart tlienart added the bug Something isn't working label Feb 16, 2023
@rikhuijzer
Copy link
Contributor

Sometimes I wish that Julia would throw compiler errors on missing function definitions.

Anyway, maybe this code was written under the assumption that the function was defined in the same package like Pluto does:

https://github.com/fonsp/Pluto.jl/blob/bedc7767d76439477bae8a5165f4f39906f9064c/src/notebook/path%20helpers.jl#L4

@tlienart
Copy link
Collaborator

Thanks a lot for that @rikhuijzer ; let's copy that function over here then!

tlienart added a commit that referenced this issue Feb 16, 2023
tlienart added a commit that referenced this issue Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants