Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version to 1.0.0. #9

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Set version to 1.0.0. #9

merged 1 commit into from
Jul 12, 2023

Conversation

fredrikekre
Copy link
Member

I think the package is ready to be released?

@goerz
Copy link
Member

goerz commented Jul 12, 2023

What do you think about #7 (comment)?

@goerz goerz force-pushed the fe/version-1.0.0 branch from bca7831 to 865c631 Compare July 12, 2023 15:02
@goerz
Copy link
Member

goerz commented Jul 12, 2023

PR in #10, but if the idea of a warning isn't popular with everyone, this is definitely optional

@goerz
Copy link
Member

goerz commented Jul 12, 2023

We'll have to remember to put a date for the release in NEWS.md, too

@goerz goerz force-pushed the fe/version-1.0.0 branch from 865c631 to f87f320 Compare July 12, 2023 20:46
@goerz
Copy link
Member

goerz commented Jul 12, 2023

Looks good to go! I've put today's date in NEWS.md. You are welcome to tag the registrator bot on this!

@fredrikekre
Copy link
Member Author

fredrikekre commented Jul 12, 2023

Ah, I also made the same edit and force pushed after a rebase on master. If you didn't add anything else I think we are good to go.

Would you like to make a Discourse announcement? I didn't find this package announced there, so would be good to do.

@fredrikekre fredrikekre merged commit a1bf286 into master Jul 12, 2023
@fredrikekre fredrikekre deleted the fe/version-1.0.0 branch July 12, 2023 21:05
@fredrikekre
Copy link
Member Author

JuliaRegistries/General#87368

@goerz
Copy link
Member

goerz commented Jul 12, 2023

Looks good, thanks! And Yes, I’ll draft an announcement for Discourse tonight. Good idea!

@goerz
Copy link
Member

goerz commented Jul 13, 2023

https://discourse.julialang.org/t/ann-documentercitations-v1-0-0/101562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants