Remove workarounds for bugs fixed in BibInternal 0.3.5 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release of `BibInternal v0.3.5` solved issue Humans-of-Julia/BibInternal.jl#22 related to preprints. Our monkey-patch of `BibInternal.make_bibtex_entry` to work around this is no longer necessary. The release also solved issue Humans-of-Julia/BibInternal.jl#21, so the description of the workaround in the documentation can be removed. Note that `BibInternal` is only an implicit dependency (via `Bibliography.jl`). The lowest compat-bound for `Bibliography.jl`, that is, `v0.2.15`, is compatible with `BibInternal v0.3.5`. So that version should be installed automatically. Someone would have to go out of their way to pin an older version of `BibInternal` in their environment. Dealing with any resulting bugs in that case is on them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release of
BibInternal v0.3.5solved issue Humans-of-Julia/BibInternal.jl#22 related to preprints. Our monkey-patch ofBibInternal.make_bibtex_entryto work around this is no longer necessary.The release also solved issue Humans-of-Julia/BibInternal.jl#21, so the description of the workaround in the documentation can be removed.
Note that
BibInternalis only an implicit dependency (viaBibliography.jl). The lowest compat-bound forBibliography.jl, that is,v0.2.15, is compatible withBibInternal v0.3.5. So that version should be installed automatically. Someone would have to go out of their way to pin an older version ofBibInternalin their environment. Dealing with any resulting bugs in that case is on them.