Merge pull request #82 from JuliaDocs/78-fix-tex-escape-initials

Un-escape TeX before generating name initials
JuliaDocs · Nov 14, 2024 · 39a8cf2 · 39a8cf2
2 parents df162b1 + 616fc4e
commit 39a8cf2
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 2 deletions.
diff --git a/docs/src/refs.bib b/docs/src/refs.bib
@@ -285,7 +285,7 @@ @phdthesis{GoerzPhd2015
 }
 
 @article{GoerzPRA2015,
-    Author = {Goerz, Michael H. and Gualdi, Giulia and Reich, Daniel M. and Koch, Christiane P. and Motzoi, Felix and Whaley, K. Birgitta and Vala, Ji\vr\'i and Müller, Matthias M. and Montangero, Simone and Calarco, Tommaso},
+    Author = {Goerz, Michael H. and Gualdi, Giulia and Reich, Daniel M. and Koch, Christiane P. and Motzoi, Felix and Whaley, K. Birgitta and Vala, Jiří and Müller, Matthias M. and Montangero, Simone and Calarco, Tommaso},
     Title = {Optimizing for an arbitrary perfect entangler. II. Application},
     Journal = pra,
     Year = {2015},

diff --git a/src/formatting.jl b/src/formatting.jl
@@ -22,7 +22,7 @@ end
 
 function _initial(name)
     initial = ""
-    _name = Unicode.normalize(strip(name))
+    _name = Unicode.normalize(tex_to_markdown(strip(name)))
     if length(_name) > 0
         initial = "$(_name[1])."
         for part in split(_name, "-")[2:end]

diff --git a/test/test_formatting.jl b/test/test_formatting.jl
@@ -413,6 +413,18 @@ end
 end
 
 
+@testset "Handling initial for tex-escaped Ł (#78)" begin
+
+    # https://github.com/JuliaDocs/DocumenterCitations.jl/issues/78
+
+    bib = CitationBibliography(joinpath(splitext(@__FILE__)[1], "issue78.bib"))
+    md(key) = format_bibliography_reference(Val(:numeric), bib.entries[key])
+    @test md("vaswani2017Attention") ==
+          "Ł. Kaiser. *Attention Is All You Need*. In: *Proceedings of the 31st International Conference on Neural Information Processing Systems* (2017)."
+
+end
+
+
 @testset "invalid DOI" begin
 
     bib = CitationBibliography(joinpath(splitext(@__FILE__)[1], "invalid_doi.bib"))

diff --git a/test/test_formatting/issue78.bib b/test/test_formatting/issue78.bib
@@ -0,0 +1,6 @@
+@inproceedings{vaswani2017Attention,
+  title = {Attention Is All You Need},
+  author = {Kaiser, {\L}ukasz},
+  year = {2017},
+  booktitle = {Proceedings of the 31st International Conference on Neural Information Processing Systems},
+}
diff --git a/test/test_tex_to_markdown.jl b/test/test_tex_to_markdown.jl
@@ -205,6 +205,8 @@ end
     @test tex_to_markdown(raw"Ga{\\\"e}tan") == "Gaëtan"
     @test tex_to_markdown(raw"C\^ot\'e") == "Côté"
     @test tex_to_markdown(raw"Gro{\ss}") == "Groß"
+    @test tex_to_markdown(raw"{\L}ukasz") == "Łukasz"
+    @test tex_to_markdown(raw"Ji\v{r}\'i") == "Jiří"
 end
 
 @testset "titles" begin