Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture PNG output in addition to SVG #738

Merged
merged 4 commits into from
Jul 9, 2018
Merged

Capture PNG output in addition to SVG #738

merged 4 commits into from
Jul 9, 2018

Conversation

davidanthoff
Copy link
Contributor

I've put it in with a lower priority for now, that seems the save way to introduce this feature.

Fixes #728.

mortenpi
mortenpi reviewed Jun 7, 2018
View reviewed changes
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks tackling this!

While we're at it, perhaps we should also add a few other common MIMEs? JPEG, GIF, WebP?

It would also be good to add a test for each of these formats into /test/examples/src/man/tutorial.md. I think the easiest thing would be to just create a new type that reads an image file and prints the file's contents the corresponding print method (wouldn't make sense to make Documenter's tests depend on Cairo or something).

@mortenpi mortenpi added this to the 0.19.0 milestone Jun 7, 2018
@davidanthoff
Copy link
Contributor Author

I added things to /test/examples/src/man/tutorial.md as you suggested.

I don't have the time to add other MIME types, all I need for my use-case is the PNG case (for now), so would be great if we could merge that for now.

@mortenpi
Copy link
Member

Hmm.. the 0.7 failures look related? I'll look into fixing the master 0.7 builds.

@fredrikekre fredrikekre mentioned this pull request Jun 26, 2018
Closed
@mortenpi
Copy link
Member

Sorry, I haven't had the time to check why this is failing on 0.7, and it might be a few weeks I get to this. The tests on master are fixed now though, so it has to be something in this PR. But once this is working on 0.7, it would be good to go as far as I am concerned, and we could also tag a release with this in.

fredrikekre referenced this pull request in JuliaLang/julia Jul 3, 2018
@stevengj @JeffBezanson
RFC: move stringmime to Base64, rename reprmime -> repr (#25990)
15a345b 
* stringmime(text/plain, x) can be replaced with repr(text/plain, x)
@fredrikekre
Copy link
Member

I think test error on 0.7 is JuliaLang/julia@15a345b#r29588023

@davidanthoff
Copy link
Contributor Author

Does that mean the test failures on 0.7 are due to a bug in julia, not this PR? Anything I need to do at this point to get this PR merged?

@fredrikekre
Copy link
Member

fredrikekre commented Jul 4, 2018 •
edited
Loading

Yea I think it is only the Julia bug, I will submit a PR to fix it soon. We can wait until that has propagated to a nightly build and then this should be good to go.

@fredrikekre
Copy link
Member

JuliaLang/julia#27927

@fredrikekre fredrikekre closed this Jul 5, 2018
@fredrikekre fredrikekre reopened this Jul 5, 2018
@fredrikekre
Copy link
Member

fredrikekre commented Jul 5, 2018 •
edited
Loading

Seems to pass on nightly now, after the Julia fix. OK to disable testing on Julia beta for now? nightly is closer to what 0.7 will be than beta anyways.

@mortenpi
Copy link
Member

mortenpi commented Jul 5, 2018

Yup, the 0.7 targets should go into allowed failures for now.

fredrikekre and others added 2 commits July 5, 2018 09:11
@fredrikekre
allow failures on 0.7-beta
632cf63
@mortenpi
Allow CI failures on win64
4081081 
The 64-bit Windows nightly binaries are behind at the moment. This
should be undone as soon as the binaries are updated again.
@mortenpi
Copy link
Member

mortenpi commented Jul 9, 2018

Since the nightly win64 binaries are lagging behind, let's put that into allowed failures as well to get a green badge and have this merged.

@mortenpi mortenpi merged commit 17a1364 into JuliaDocs:master Jul 9, 2018
@mortenpi mortenpi mentioned this pull request Jul 9, 2018
Merged
@davidanthoff davidanthoff deleted the png-capture branch July 10, 2018 07:44
@mortenpi mortenpi mentioned this pull request Jul 23, 2018
Merged
@mortenpi mortenpi mentioned this pull request Jul 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenpi mortenpi mortenpi left review comments

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@davidanthoff @mortenpi @fredrikekre