Make user-agent for linkchecks customisable #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
force-pushed
the
mg/linkcheck-user-agent
branch
from
9b70146 to
7616371
Compare
|
I think it's a good idea to have an option for this, even though for you use case, #2569 should also fix it. So do I want to merge this too. The implementation looks fine, just needs docs and a CHANGELOG note. |
Co-authored-by: Mosè Giordano <[email protected]>
|
Thanks @giordano! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2557. Untested, also because I don't know how to use this new option, but I followed #1295 as a template to follow to add a custom user agent.