-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HTML docs #217
Update HTML docs #217
Conversation
Current coverage is 82.49% (diff: 100%)@@ master #217 diff @@
==========================================
Files 20 20
Lines 1474 1474
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 1249 1216 -33
- Misses 225 258 +33
Partials 0 0
|
@@ -667,6 +669,7 @@ if isdefined(Base.Markdown, :Admonition) | |||
div[".admonition-text"](mdconvert(a.content, a)) | |||
) | |||
end | |||
mdconvert(c::Markdown.Code, parent::Markdown.Admonition) = mdconvert_codeblock(c, parent) | |||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other toplevel blocks should also have this change, not just Admonition
s and MD
s, correct? BlockQuote
, Footnote
, and List
elements as well?
CSS changes look good to me. |
Should be backported to |
ed6ca9a
to
3e8996a
Compare
Yes, indeed, forgot those. Also, I did notice that parsing lists can run into issues if the whitespace is inconsistent, i.e. in this
some of it gets wrapped in paragraphs, the math block doesn't get parsed etc. Not sure if they're bugs though actually -- with consistent whitespace everything seems to work.
Probably, I suppose. I guess we should do bugfixes for the HTML part on |
Technically the commonmark "spec" is quite lenient with indentation, but I've gone with requiring consistent indentation so that all docs will be just a little bit more uniform (which I think is a good thing).
Yes, wherever we can backport non-invasive things we probably should. It can wait 'til this is merged to |
Yup, I agree that we should change that. I'd do that in a separate PR though, since it also requires changes to the rendering code. Shall we merge? |
Markdown.Code and Markdown.LaTeX nodes should also be rendered as blocks in other contexts besides Markdown.MD too. Specifically, instead of only checking for Markdown.MD, we'll dispatch on a Union of all the block-context nodes when we want to determine block vs. inline based on the parent node.
In docstrings and admonitions the headers should be smaller than in the top level context.
3e8996a
to
896afb5
Compare
Fix some mistakes and add a few details to the "Output formats" section. The style and code block changes are required so that the updated docs would render correctly.
The rendered version, including the style of
<h1>
in admonitions vs a top-level<h2>
: