Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compress css #2157

Merged
merged 4 commits into from
Jun 29, 2023
Merged

feat: compress css #2157

merged 4 commits into from
Jun 29, 2023

Conversation

pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Jun 28, 2023

Generated with Sass.compile_file("scss/documenter-light.scss", "themes/documenter-light.css"; output_style=Sass.compressed)

assets/html/themes on master
❯ ll
total 768K
-rw-r--r-- 1 pfitzseb pfitzseb 450K Jun 28 12:10 documenter-dark.css
-rw-r--r-- 1 pfitzseb pfitzseb 313K Jun 28 12:10 documenter-light.css

assets/html/themes on sp/compress-css
❯ ll 
total 644K
-rw-r--r-- 1 pfitzseb pfitzseb 381K Jun 28 12:08 documenter-dark.css
-rw-r--r-- 1 pfitzseb pfitzseb 258K Jun 28 12:09 documenter-light.css

Doesn't save too much space, but ~20% is not nothing.

Fixes #2153.

Generated with `Sass.compile_file("scss/documenter-light.scss", "themes/documenter-light.css"; output_style=Sass.compressed)`
@mortenpi
Copy link
Member

We should make this the default in DocumenterTools. That would also fix the CI.

@mortenpi mortenpi added Type: Enhancement Format: HTML Related to the default HTML output labels Jun 29, 2023
@mortenpi mortenpi merged commit 7ee9e1a into master Jun 29, 2023
@mortenpi mortenpi deleted the sp/compress-css branch June 29, 2023 08:54
@mortenpi
Copy link
Member

Thanks!

@mortenpi mortenpi mentioned this pull request Jul 3, 2023
mortenpi added a commit that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minify the theme CSS files
2 participants