[LaTeXWriter] fix escaping in header titles #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a test here that should hopefully fail: e1396e5 (that branch is off current master). |
odow
commented
May 26, 2023
|
I got the test to finally fail on master, so I took the liberty of pushing it here. |
|
It looks like the JuMP build also passed with this fix? |
|
Yip. Although now I need to tweak again, because it made every docstring a Chapter 😆 |
|
Let's hope it doesn't reveal more bugs -- I'll go ahead and merge this 😆 |
mortenpi
pushed a commit
that referenced
this pull request
Jul 3, 2023
(cherry picked from commit 025b58c)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the culprit of jump-dev/JuMP.jl#3386. I'll test on this branch before adding tests etc.