-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump checkout to v3 and mention needed permissions #2038
Conversation
I believe it should be possible to set the permissions only for this job, see e.g. https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#assigning-permissions-to-a-specific-job |
Yes, I think this should be sufficient? permissions:
contents: write |
Ok, I updated the PR to list both options. |
Actually, if you don't mind, that would be good. In my opinion, in general, you want the additional permissions to be as close to where you are using them. So I think we should suggest |
Done. Feel free to reformat further if you really like those long lines. The problem with long lines (IMHO) is that they lead to big diffs in the repo when anyone changes one small part of a long line. See the current file diff where I changed "taken from" to "based on" - that tiny change causes a big diff. But it's up to you :) |
LGTM, thanks! |
My cleanup job kept failing and it took me a while to realize it was a repo permissions issue.
Hopefully having a brief note here will help others (and my future self).