Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tex] Adjusting the TOC style #1750

Merged
merged 6 commits into from
Mar 4, 2022
Merged

[tex] Adjusting the TOC style #1750

merged 6 commits into from
Mar 4, 2022

Conversation

inkydragon
Copy link
Contributor

@inkydragon inkydragon commented Jan 14, 2022

xref: JuliaLang/julia#43698

  1. Use compact line spacing in TOC: \cftbeforepartskip, \cftbeforechapterskip
  2. Increase the spacing between chapter numbers and chapter names: \cftchapternumwidth
  3. Increase indent before section number: \cftsectionindent

image

output: DocumenterLaTeX-toc#1750.pdf v.s. DocumenterLaTeX-master+7beb208b3.pdf

@inkydragon
Copy link
Contributor Author

This pr does not modify the display depth in the TOC (\settocdepth).

And with only the chapter names (\settocdepth{chapter}):
image

DocumenterLaTeX-chapter-only.pdf

@ViralBShah
Copy link
Contributor

Any idea about the failing test? Maybe rebase?

@fredrikekre Is merging this what we broadly need for the pdf of the julia manual to look nicer, and is this the right place (as opposed to the julia repo PR linked above)?

@ViralBShah
Copy link
Contributor

@inkydragon Can you look into the failing test? It looks relevant.

@fredrikekre
Copy link
Member

Looks good, I don't think the failure is related, I can look at it tomorrow.

Can you add a note in the changelog?

@ViralBShah
Copy link
Contributor

Bump.

@fredrikekre
Copy link
Member

Tests should be fixed by 33c53bd.

@ViralBShah
Copy link
Contributor

@inkydragon Can you rebase to pull in the fix above to fix the failing test?

@ViralBShah ViralBShah merged commit 36ae8ef into JuliaDocs:master Mar 4, 2022
@mortenpi mortenpi added Type: Enhancement Format: LaTeX Related to the LaTeX / PDF output labels Mar 24, 2022
@ViralBShah
Copy link
Contributor

We still have spacing issues - however I think that the PDF should only have TOC depth at chapter level (and not section level)

Screen Shot 2022-04-03 at 11 03 36 AM

@inkydragon inkydragon deleted the toc branch March 24, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: LaTeX Related to the LaTeX / PDF output Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants