[RFC] Tweak color schemes #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will update the definition of basic color variables such as `$red`. This also tweaks the ANSI colors by deriving from those basic colors. However, the colors for admonitions etc. are kept as they are, for compatibility.
Merged
|
This LGTM, thanks @kimikage! Is it ready to go on your end as well or was there something else you wanted to tweak here? |
Perhaps I may want to make a few more tweaks in the future, but the changes are likely to be minor and can be addressed in a future version, not here. 😄 My concern is that not a few people would prefer a vivid theme like Monokai. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will update the definition of basic color variables such as
$red. This also tweaks the ANSI colors by deriving from those basic colors.However, the colors for admonitions etc. are kept as they are, for compatibility.
Closes #1629